-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All tests passed with vector coordinates #27
base: dev_master_x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one fill to remove.
It looks good. Could you generate a dev branch for your traine where you wiil pull you updates on ? at the end of you trainee, we will see how far we will be able to update main.
rocket_twin/tests/test_temp.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we will make the pull request to the dev_master_x branch from now on.
Regarding the test_temp, we will remove it eventually, but for now it is usefull for us to check that the system remains consistent with physics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a new test to check what you want to chck with the tmp file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted it for now, before adding a test that will look more like a test
Not sure about the pre commit